add FastCDC chunking function to RPCs#11299
Merged
tyler-french merged 1 commit intomasterfrom Feb 11, 2026
Merged
Conversation
tyler-french
changed the title
tyler-french
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes chunking function handling for the SplitBlob / SpliceBlob CAS RPCs and advertises FastCDC parameters via server capabilities, aligning server behavior around FastCDC_2020 as the supported algorithm.
Changes:
- Validate
chunking_functioninSplitBlob(accept UNKNOWN and FAST_CDC_2020) andSpliceBlob(currently only FAST_CDC_2020). - Populate
chunking_functionin SplitBlobResponse and SpliceBlobRequest generated from chunking manifests (always FAST_CDC_2020). - Advertise
FastCdc_2020Paramsin cache capabilities when chunking is enabled.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| server/remote_cache/content_addressable_storage_server/content_addressable_storage_server.go | Adds request validation for chunking function in SplitBlob / SpliceBlob RPC handlers. |
| server/remote_cache/chunking/chunking.go | Adds FAST_CDC_2020 chunking function fields to generated RPC request/response protos. |
| server/remote_cache/capabilities_server/capabilities_server.go | Advertises FastCDC_2020 parameters when chunking is enabled. |
| server/remote_cache/capabilities_server/BUILD | Adds chunking package dependency for capabilities server. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
server/remote_cache/content_addressable_storage_server/content_addressable_storage_server.go
Outdated
Show resolved
Hide resolved
tyler-french
force-pushed
the
tfrench/chunking-function
branch
2 times, most recently
from
8703a71 to
0c14107
Compare
tyler-french
force-pushed
the
tfrench/chunking-function
branch
from
0c14107 to
5fa5ce1
Compare
bduffany
reviewed
Feb 10, 2026
tyler-french
force-pushed
the
tfrench/chunking-function
branch
from
5fa5ce1 to
5d8a139
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
server/remote_cache/content_addressable_storage_server/content_addressable_storage_server.go
Show resolved
Hide resolved
server/remote_cache/content_addressable_storage_server/content_addressable_storage_server.go
Show resolved
Hide resolved
fmeum
approved these changes
Feb 11, 2026
tyler-french
force-pushed
the
tfrench/chunking-function
branch
from
5d8a139 to
503fa23
Compare
bduffany
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split accepts Unknown and FastCDC, always returns FastCDC. Splice accepts Unknown and FastCDC. No need to overcomplicate and add more chunking functions we don't accept yet. In the future, we can store the unknown and fastcdc separately. For now, a new call to
Splicewill always overwrite for a given blob digest, similar to the AC.