cleanup: remove flipped quota flag#11351
Merged
tyler-french merged 1 commit intomasterfrom Feb 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the quota.disallow_blocked_groups feature flag which is now permanently enabled in both dev and prod environments. The flag controlled whether blocked groups would be prevented from making requests through the quota manager.
Changes:
- Removed the feature flag check from the
checkGroupBlockedmethod, making the blocking behavior always active - Simplified tests by removing redundant test cases that checked flag-on/flag-off scenarios
- Consolidated test setup to happen once at the test function level rather than in each subtest
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| enterprise/server/quota/quota_manager.go | Removed the disallowBlockedGroupsFlagKey constant and the conditional flag check, making blocked group checking unconditional |
| enterprise/server/quota/quota_manager_test.go | Simplified tests by removing redundant test cases for flag-enabled/disabled scenarios and consolidating test setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tyler-french
force-pushed
the
tfrench/flag-blocked-cleanup
branch
from
ef6ee9e to
c16c931
Compare
tyler-french
force-pushed
the
tfrench/flag-blocked-cleanup
branch
from
c16c931 to
f55da25
Compare
tyler-french
force-pushed
the
tfrench/flag-blocked-cleanup
branch
from
f55da25 to
220562d
Compare
tyler-french
requested review from
maggie-lou
and removed request for
bduffany
maggie-lou
approved these changes
Feb 25, 2026
Collaborator
maggie-lou
left a comment
maggie-lou
left a comment
There was a problem hiding this comment.
Reminder to cleanup the flag in the -internal repo as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is enabled in dev and prod. If a group status is set to blocked, it will behave that way.
This only affects the enterprise/server with quota manager enabled and group statuses.