Skip to content

feat(chunking): support Split/Splice in bb print#11363

Merged
tyler-french merged 1 commit intomasterfrom
tfrench/bbprint
Feb 23, 2026
Merged

feat(chunking): support Split/Splice in bb print#11363
tyler-french merged 1 commit intomasterfrom
tfrench/bbprint

Conversation

@tyler-french
Copy link
Contributor

@tyler-french tyler-french commented Feb 20, 2026

This is needed to run bb print to see Split/Splice calls, to test bazelbuild/bazel#28437

BB print just reads the grpc log directly from whats in this file, so updating this file is sufficient.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for logging SplitBlob and SpliceBlob RPC calls in the remote execution log proto, enabling the bb print command to display these chunking-related operations. This is needed to test the Split/Splice functionality referenced in the linked Bazel PR.

Changes:

  • Added two new proto message types (SplitBlobDetails and SpliceBlobDetails) to capture request/response details for chunking operations
  • Extended the RpcCallDetails oneof to include the new message types with field numbers 15 and 16
Comments suppressed due to low confidence (2)

proto/remote_execution_log.proto:127

  • There is an extra blank line here that deviates from the consistent spacing pattern used throughout the rest of this proto file. The standard convention is to have a single blank line between message definitions, but this adds two blank lines. Remove one blank line to maintain consistency with the rest of the file.
    proto/remote_execution_log.proto:140
  • There is an extra blank line here that deviates from the consistent spacing pattern used throughout the rest of this proto file. The standard convention is to have a single blank line between message definitions, but this adds two blank lines. Remove one blank line to maintain consistency with the rest of the file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tyler-french tyler-french changed the title feat(chunking): support Split/Splice in bb print feat(chunking): support Split/Splice in bb print Feb 22, 2026
@tyler-french tyler-french merged commit f0ce114 into master Feb 23, 2026
10 of 14 checks passed
@tyler-french tyler-french deleted the tfrench/bbprint branch February 23, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants