feat: add upload/download by group to metrics#11393
Merged
tyler-french merged 1 commit intomasterfrom Feb 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds per-organization (group) tracking to remote cache upload and download metrics by adding the group_id label to cache size metrics and creating corresponding Grafana dashboard panels. This enables monitoring of cache usage patterns on a per-organization basis, which is valuable for understanding usage trends and identifying potential issues with specific groups.
Changes:
- Added
GroupIDlabel toCacheUploadSizeBytesandCacheDownloadSizeByteshistogram metrics - Updated metric recording in hit tracker to include group IDs when observing cache transfer sizes
- Added two new Grafana dashboard panels showing download and upload throughput broken down by group ID
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/metrics/metrics.go | Added GroupID to label lists for CacheDownloadSizeBytes and CacheUploadSizeBytes metrics |
| server/remote_cache/hit_tracker/hit_tracker.go | Updated metric observation calls to include groupID in the label sets for cache upload and download size metrics |
| tools/metrics/grafana/dashboards/buildbuddy.json | Added two new timeseries panels for visualizing download and upload throughput per group |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bduffany
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is helpful information to see for changes over time, and unexpected traffic patterns.
We can see similar information for executions, and its useful to correlate traffic from the cache and the executors.
Adding to the "Internal" section as this is likely not helpful to others—we can move it to the "remote cache" section if others want it.