Skip to content

feat: add upload/download by group to metrics#11393

Merged
tyler-french merged 1 commit intomasterfrom
tfrench/group-dl
Feb 24, 2026
Merged

feat: add upload/download by group to metrics#11393
tyler-french merged 1 commit intomasterfrom
tfrench/group-dl

Conversation

@tyler-french
Copy link
Contributor

@tyler-french tyler-french commented Feb 23, 2026

This is helpful information to see for changes over time, and unexpected traffic patterns.

We can see similar information for executions, and its useful to correlate traffic from the cache and the executors.

Adding to the "Internal" section as this is likely not helpful to others—we can move it to the "remote cache" section if others want it.

Copilot AI review requested due to automatic review settings February 23, 2026 21:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds per-organization (group) tracking to remote cache upload and download metrics by adding the group_id label to cache size metrics and creating corresponding Grafana dashboard panels. This enables monitoring of cache usage patterns on a per-organization basis, which is valuable for understanding usage trends and identifying potential issues with specific groups.

Changes:

  • Added GroupID label to CacheUploadSizeBytes and CacheDownloadSizeBytes histogram metrics
  • Updated metric recording in hit tracker to include group IDs when observing cache transfer sizes
  • Added two new Grafana dashboard panels showing download and upload throughput broken down by group ID

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
server/metrics/metrics.go Added GroupID to label lists for CacheDownloadSizeBytes and CacheUploadSizeBytes metrics
server/remote_cache/hit_tracker/hit_tracker.go Updated metric observation calls to include groupID in the label sets for cache upload and download size metrics
tools/metrics/grafana/dashboards/buildbuddy.json Added two new timeseries panels for visualizing download and upload throughput per group

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tyler-french tyler-french merged commit 0428d09 into master Feb 24, 2026
15 of 18 checks passed
@tyler-french tyler-french deleted the tfrench/group-dl branch February 24, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants