Tag image fetch metrics with use_oci_fetcher experiment label#11411
Merged
dan-stowell merged 1 commit intomasterfrom Feb 26, 2026
Merged
Tag image fetch metrics with use_oci_fetcher experiment label#11411dan-stowell merged 1 commit intomasterfrom
dan-stowell merged 1 commit intomasterfrom
Conversation
Add a 'use_oci_fetcher' label to the ImageFetchDurationUsec histogram so we can compare latency and error rates between the OCI fetcher experiment path and the standard path. - Add ImageFetchUseOCIFetcherLabel constant and add it to the histogram - Add useOCIFetcher bool parameter to PullImageIfNecessary and RecordImageFetchMetrics - Thread the value from each caller: ociruntime and firecracker pass their stored useOCIFetcher field, podman/docker pass false, runner passes PlatformProperties.UseOCIFetcher Co-authored-by: Shelley <shelley@exe.dev>
bduffany
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a 'use_oci_fetcher' label to the ImageFetchDurationUsec histogram so we can compare latency and error rates between the OCI fetcher experiment path and the standard path.