Skip to content

Make one more execution_server dep required#11417

Merged
vanja-p merged 3 commits intomasterfrom
vanja-deps
Feb 27, 2026
Merged

Make one more execution_server dep required#11417
vanja-p merged 3 commits intomasterfrom
vanja-deps

Conversation

@vanja-p
Copy link
Contributor

@vanja-p vanja-p commented Feb 25, 2026

This is a follow up on #11251, which is possible after the changes in #11283.

This is a follow up on #11251, which is possible after the changes in #11283.
@vanja-p vanja-p requested a review from dan-stowell February 26, 2026 18:35
@vanja-p
Copy link
Contributor Author

vanja-p commented Feb 26, 2026

PTAL. I had to pull out capabilities server from libmain.RegisterLocalServersAndClients. I'm not sure if the amount of refactoring is worth it.

@vanja-p vanja-p requested a review from bduffany February 26, 2026 18:36
@bduffany
Copy link
Member

bduffany commented Feb 26, 2026

@vanja-p my interpretation is that RegisterLocalServersAndClients was kind of tangled up because it both registers the "base" dependencies needed by OSS + enterprise, but at the same time it has enterprise dependencies. So I think in that sense, it does seem worth breaking the circular dependency chain there, even though it's a little awkward to have to register the capabilities server in two different places.

@vanja-p vanja-p merged commit b31f3a4 into master Feb 27, 2026
13 checks passed
@vanja-p vanja-p deleted the vanja-deps branch February 27, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants