Move more API key read paths to centralized query.#11452
Merged
vadimberezniker merged 3 commits intomasterfrom Mar 2, 2026
Merged
Move more API key read paths to centralized query.#11452vadimberezniker merged 3 commits intomasterfrom
vadimberezniker merged 3 commits intomasterfrom
Conversation
vadimberezniker
added a commit
that referenced
this pull request
Feb 28, 2026
vadimberezniker
added a commit
that referenced
this pull request
Feb 28, 2026
bduffany
approved these changes
Mar 2, 2026
| return grpb.Group_GroupStatus(g.Status) | ||
| } | ||
|
|
||
| // apiKeyGroupFullData contains full API key data and data for the owning group. |
Member
There was a problem hiding this comment.
nit: the scope of this struct seems unclear because of its name - maybe add an explicit comment about how this is different from apiKeyGroup and how it's used. Or ideally use a clearer name
Member
Author
There was a problem hiding this comment.
I renamed it to apiKeyGroupRow and beefed up the description.
The lookup is going to become more complex and it won't make sense for each caller to execute the necessary queries.
vadimberezniker
force-pushed
the
consolidate_api_key_query_2
branch
from
c6e13a9 to
f077160
Compare
vadimberezniker
added a commit
that referenced
this pull request
Mar 2, 2026
vadimberezniker
added a commit
that referenced
this pull request
Mar 2, 2026
vadimberezniker
added a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #11448