Skip to content

feat: add a flag to disable API key readback#11460

Merged
bduffany merged 1 commit intomasterfrom
auth-feat-reqs
Mar 4, 2026
Merged

feat: add a flag to disable API key readback#11460
bduffany merged 1 commit intomasterfrom
auth-feat-reqs

Conversation

@bduffany
Copy link
Member

@bduffany bduffany commented Mar 2, 2026

Context: https://buildbuddy-corp.slack.com/archives/C01H6DW5UFL/p1772211902400119?thread_ts=1772199877.792549&cid=C01H6DW5UFL

A customer requested to be able to disable readback of API keys in the UI (i.e. make them accessible via the UI / API only once, when they are created). This seemed like a nice/reasonable security feature to add, and we might want to enable this in our cloud UI as well at some point (making it an org-level preference to start with, maybe).

image

@bduffany bduffany force-pushed the auth-feat-reqs branch 2 times, most recently from 6a3067d to 398154d Compare March 2, 2026 18:50
@bduffany bduffany requested a review from sluongng March 2, 2026 18:50
@bduffany bduffany marked this pull request as ready for review March 2, 2026 18:54
Copy link
Member

@siggisim siggisim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - what happens to the quickstart guide if this flag is enabled (fine for now, but if we enable in prod we probably want to think that through)

@sluongng
Copy link
Contributor

sluongng commented Mar 2, 2026

I suspect we just gona show an environment variable in quick start page. Or we can use bb login and then tell user to use bb as a credentials helper

@bduffany
Copy link
Member Author

bduffany commented Mar 2, 2026

I just remembered the Quickstart thing right after I sent for review 😅 also remembered we have TLS cert downloads which should probably also be subject to the same logic. Working on both things now

@bduffany
Copy link
Member Author

bduffany commented Mar 2, 2026

re Quickstart I added an instruction "To create a new API key or certificate, see Settings." I made this show unconditionally since I think it's helpful even without this PR. The "or certificate" part is conditioned on whether certs are enabled.

Before (the plaintext key is useless - it's a localhost key :P ):

image

After:

image

Also updated the settings page to show a download button for certs.

@bduffany bduffany force-pushed the auth-feat-reqs branch 14 times, most recently from 33d3b4b to 6be24cf Compare March 3, 2026 18:28
@bduffany bduffany merged commit a35692d into master Mar 4, 2026
13 checks passed
@bduffany bduffany deleted the auth-feat-reqs branch March 4, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants