Conversation
| go_library( | ||
| name = analyzer, | ||
| srcs = ["analyzer.go"], | ||
| importpath = "github.com/buildbuddy-io/buildbuddy/rules/go/analyzer/" + analyzer, |
There was a problem hiding this comment.
Why do we need a wrapper target? Could we also just link the selected analyzers into a single target?
There was a problem hiding this comment.
hmm do you mean to combine their Run func inside a for loop?
That's another way to do this. Do you prefer that over this?
There was a problem hiding this comment.
Im just gona roll with this wrapper target as-is.
We can turn it into a combined analyzer in the future if that's better.
sluongng
force-pushed
the
sluongng/nogo-modernize
branch
2 times, most recently
from
4723f6f to
b38e3dc
Compare
|
how's the performance of this btw? I noticed when playing around with |
This create an outter shell to start using the mordernize analyzers in our code base to upgrade the Go syntax. All the analyzers are disabled by default. In subsequent commits, we shall turn them on one by one and apply the fixes appropriately.
sluongng
force-pushed
the
sluongng/nogo-modernize
branch
from
b38e3dc to
fa8277e
Compare
|
This uses nogo, which is an additional validation action running on each Since we already have nogo setup, this does not add much overhead. |
3 participants
This create an outter shell to start using the mordernize analyzers in
our code base to upgrade the Go syntax.
All the analyzers are disabled by default.
In subsequent commits, we shall turn them on one by one and apply the
fixes appropriately.