Replace the imageExistsCache in podman.go with an lru.LRU#11581
Merged
iain-macdonald merged 1 commit intomasterfrom Mar 13, 2026
Merged
Replace the imageExistsCache in podman.go with an lru.LRU#11581iain-macdonald merged 1 commit intomasterfrom
iain-macdonald merged 1 commit intomasterfrom
Conversation
iain-macdonald
force-pushed
the
im/9061d0e4831
branch
2 times, most recently
from
17f10e8 to
bc7c7fe
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies podman image-existence caching by replacing the custom imageExistsCache wrapper with the shared server/util/lru cache configured with TTL and thread-safety. This keeps the same “cache positive podman image exists results for a short time” behavior while removing bespoke locking/TTL logic.
Changes:
- Replace
*imageExistsCachewithlru.LRU[struct{}]inProviderandpodmanCommandContainer. - Initialize the cache via
lru.NewusingTTL,MaxSize, andThreadSafe. - Update call sites to use
ContainsandAdd(key, value)and remove the custom cache type.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
vanja-p
approved these changes
Mar 13, 2026
| } | ||
|
|
||
| imageExistsCache, err := newImageExistsCache() | ||
| imageExistsCache, err := lru.New[struct{}](&lru.Config[struct{}]{ |
Contributor
There was a problem hiding this comment.
nit: you don't need the type parameter on New, since it infers it from the config.
Contributor
Author
There was a problem hiding this comment.
good call, done
iain-macdonald
force-pushed
the
im/9061d0e4831
branch
from
bc7c7fe to
2b3154c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.