Merged
Conversation
bduffany
reviewed
Mar 13, 2026
bduffany
approved these changes
Mar 13, 2026
Member
There was a problem hiding this comment.
ah nvm I guess we do need this because it's how we disambiguate child invocations in the case of retries. Maybe @maggie-lou can take another look at this though because I think she added that linkage originally
maggie-lou
reviewed
Mar 16, 2026
| const ( | ||
| BuildBuddyAPIKeyEnvVarName = "BUILDBUDDY_API_KEY" | ||
| BuildBuddyInvocationIDEnvVarName = "BUILDBUDDY_INVOCATION_ID" | ||
| BuildBuddyRunIDEnvVarName = "BUILDBUDDY_RUN_ID" |
Collaborator
There was a problem hiding this comment.
Rename to BUILDBUDDY_PARENT_RUN_ID?
Member
There was a problem hiding this comment.
I think BUILDBUDDY_RUN_ID might be more consistent with the existing BUILDBUDDY_INVOCATION_ID ? since both are referring to the parent ci_runner run / invocation
Member
Author
There was a problem hiding this comment.
That's what I was inspired by. Cool with either but I was trying to match what we ahve.
maggie-lou
reviewed
Mar 16, 2026
maggie-lou
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should be set in the env so that non-bazel tools can pick it up and send it back via PARENT_RUN_ID metadata to show up as linked workflow child invocations. LMK if there's a better way / something I'm missing here?