Make the lru.LRU in remoteauth.go thread-safe and remove the external mutex#11589
Merged
iain-macdonald merged 1 commit intomasterfrom Mar 13, 2026
Merged
Make the lru.LRU in remoteauth.go thread-safe and remove the external mutex#11589iain-macdonald merged 1 commit intomasterfrom
iain-macdonald merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the enterprise remote authenticator’s JWT cache to rely on server/util/lru’s built-in thread-safety instead of maintaining a separate mutex in remoteauth.go.
Changes:
- Construct the JWT LRU cache with
ThreadSafe: true. - Remove the
sync.RWMutexfromRemoteAuthenticatorand delete the associated lock/unlock calls around cache access.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| SizeFn: func(v string) int64 { return 1 }, | ||
| MaxSize: jwtCacheSize, | ||
| SizeFn: func(v string) int64 { return 1 }, | ||
| ThreadSafe: true, |
Contributor
There was a problem hiding this comment.
hah, this had a race before. LRU.Get modifies the data structure, so it can't use RLock.
Contributor
Author
There was a problem hiding this comment.
nice, glad we fixed it :-)
vanja-p
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.