Remove ipRulesProvider.get's skipRule parameter

[iain-macdonald]

Related issues: https://github.com/buildbuddy-io/buildbuddy-internal/issues/6797

[Copilot]

Pull request overview

This PR refactors the IP rules enforcement API to remove the skipCache flag, replacing it with an explicit cache invalidation method, and updates the IP rules service + tests to use the new flow.

Changes:

• Update interfaces.IPRulesEnforcer to add InvalidateCache() and simplify Check() signature.
• Update ip_rules_service to invalidate cached rules before performing lockout-prevention checks.
• Rework ip_rules_enforcer caching to retain rule IDs in cached entries so skipRuleID can be applied at check time.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
server/interfaces/interfaces.go	Adjusts IPRulesEnforcer interface to add cache invalidation and simplify Check.
enterprise/server/ip_rules_service/ip_rules_service.go	Uses InvalidateCache() before Check() when enabling enforcement or validating rule deletion.
enterprise/server/ip_rules_service/ip_rules_service_test.go	Updates fake enforcer + assertions to reflect the new invalidation/check call sequence.
enterprise/server/ip_rules_enforcer/ip_rules_enforcer.go	Introduces ipRule (ID + CIDR) cache entries, adds invalidation plumbing, and updates Check() behavior.
enterprise/server/ip_rules_enforcer/ip_rules_enforcer_test.go	Updates tests for the new Check() signature.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[vanja-p]

This type has some weird stuff going on with exports. It's not exported, but it's method are, but the method operate on the unexported ipRule type.

[iain-macdonald]

I'd like to just use an lru.LRU as an implementation, so the methods need to be public, unless I'm missing something.