Fix false URL mismatch detection with insteadOf#3718
Open
rajatvig wants to merge 2 commits intobuildkite:mainfrom
Open
Fix false URL mismatch detection with insteadOf#3718rajatvig wants to merge 2 commits intobuildkite:mainfrom
rajatvig wants to merge 2 commits intobuildkite:mainfrom
Conversation
When url.*.insteadOf is configured in gitconfig (e.g., to rewrite SSH to HTTPS for GitHub Apps auth), `git remote get-url` returns the transformed URL, not the stored URL. This causes false URL mismatch detection and unnecessary fsck/gc runs on every checkout. Use `git config --get remote.origin.url` instead, which returns the raw stored URL without insteadOf transformation. Signed-off-by: Rajat Vig <rvig@etsy.com>
rajatvig
force-pushed
the
fix-insteadof-url-mismatch
branch
from
c4eff69 to
41bb1f7
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4eff69968
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
nazzzzz
approved these changes
Feb 25, 2026
Signed-off-by: Rajat Vig <rvig@etsy.com>
nazzzzz
approved these changes
Feb 25, 2026
Author
|
@DrJosh9000 Cpuld you please when you have time recut the change? We're seeing increased times when using GitHub Apps to clone for large repositories |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git config --get remote.origin.urlinstead ofgit remote get-url originto get the raw stored URL withoutinsteadOftransformationfsck/gcruns whenurl.*.insteadOfis configured (e.g., to rewrite SSH to HTTPS for GitHub Apps auth)Problem
When
url.*.insteadOfis configured in gitconfig,git remote get-urlreturns the transformed URL, not the stored URL:git@github.com:org/repo.gitgit remote get-urlreturns:https://github.com/org/repo.git(due to insteadOf)git@github.com:org/repo.gitTest plan
go fmt ./...- no changes neededgo test ./internal/job/...- all tests pass