Configuration console command#54
Merged
Merged
Conversation
Contributor
Author
|
@shcherbanich should configuration command support all configuration keys or just collections? |
Contributor
|
Ideally, this command should support the output of all keys |
seanmcn
requested changes
Oct 31, 2023
Collaborator
There was a problem hiding this comment.
Overall it looks good thank you!
I've requested some minor changes around logging messages.
I also think it would be nice if the command could output all configuration, as a user will be unlikely to iniitally know the config keys available.
Finally, there are merge conflicts on the branch (due to the generated documentation), so please merge 1.x.x into the branch again & regenerate the documentation.
Thanks 😃
# Conflicts: # docs/shared_c.cache # docs/tech/map.md # src/Console/App.php
seanmcn
approved these changes
Nov 20, 2023
Collaborator
|
@misantron thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Configuration console command to display config settings
Issue ticket number and link
#48
Checklist before requesting a review