Make consistent with #2771#4354
Merged
Merged
Conversation
Collaborator
|
Thanks. I don't have super strong opinions one way or another, but there are several other places where we follow the pattern you're refactoring away from: Do you want to make this change across all of these similar implementations? |
Contributor
Author
|
@sjudd Thank you for your comment. I have now requested access to the document. |
Collaborator
|
Ugh sorry, wrong link, here's the right one: |
Contributor
Author
|
I've modified all |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #2771,
HttpUrlFetcher#loadDatawas refactored (here), but its similar method,AssetPathFetcher#loadDatawas not modified.I thought the modification is needed for consistency.
Motivation and Context
This PR makes this project stay consistent.