Pass multiple app argument to brew reinstall

[Mick235711]

This PR tries to change the way brew cu calls brew reinstall, so that only one command brew reinstall app1 app2 ... is issued instead of calling reinstall for each app. This has multiple advantages:

• Avoid entering the root password multiple times (Should fix Avoid entering multiples root prompts when upgrading multiple casks #266).
• Since brew already has parallel download support, this should also resolve [FR]Parallelization of downloads #160 with no extra efforts needed.

Interactive mode is also supported, as the apps are already collected anyway. MAS apps are passed as a single command to mas upgrade too.

The output is changed to "Update N apps", and the version for updated apps is printed if -v is passed. The version format mirrors the vanilla brew upgrade format.

Screenshot:

[ondrejfuhrer]

Hey @Mick235711
Thank you for your contribution. However for some reason it doesn't really work for me, I don't get any progress 🤔 any idea why is that?

It seemed "stuck", then it went to the mas apps but in the end, no casks were updated

[Mick235711]

That's an interesting behavior. "Stuck" seems to be mas doing its thing, because the current logic first updates the MAS apps and only after mas upgrade finishes will the normal casks start updating... Does it work without --include-mas?

[ondrejfuhrer]

That's an interesting behavior. "Stuck" seems to be mas doing its thing, because the current logic first updates the MAS apps and only after mas upgrade finishes will the normal casks start updating... Does it work without --include-mas?

Yes, without MAS it seems to work 🤔 Should we preserve the same order that we have right now, Casks first and after MAS? And I'll check what's going on with my MAS 😅

[Mick235711]

Sure, I can switch the order such that casks are upgraded first.

[ondrejfuhrer]

After I pulled the newest changes, getting this:

Error: undefined method 'downcase' for nil
Warning: Removed Sorbet lines from backtrace!
Rerun with `--verbose` to see the original backtrace
/opt/homebrew/Library/Taps/buo/homebrew-cask-upgrade/lib/bcu/command/upgrade.rb:264:in 'block in Bcu::Upgrade#mas_load_outdated'
/opt/homebrew/Library/Taps/buo/homebrew-cask-upgrade/lib/bcu/command/upgrade.rb:262:in 'Array#each'
/opt/homebrew/Library/Taps/buo/homebrew-cask-upgrade/lib/bcu/command/upgrade.rb:262:in 'Bcu::Upgrade#mas_load_outdated'
/opt/homebrew/Library/Taps/buo/homebrew-cask-upgrade/lib/bcu/command/upgrade.rb:95:in 'Bcu::Upgrade#include_mas_applications'
/opt/homebrew/Library/Taps/buo/homebrew-cask-upgrade/lib/bcu/command/upgrade.rb:34:in 'Bcu::Upgrade#run_process'
/opt/homebrew/Library/Taps/buo/homebrew-cask-upgrade/lib/bcu/command/upgrade.rb:10:in 'Bcu::Upgrade#process'
/opt/homebrew/Library/Taps/buo/homebrew-cask-upgrade/lib/bcu.rb:24:in 'Bcu.process'
/opt/homebrew/Library/Taps/buo/homebrew-cask-upgrade/cmd/brew-cu.rb:75:in '<main>'
<internal:/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.4.7/lib/ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:37:in 'Kernel#require'
<internal:/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.4.7/lib/ruby/3.4.0/rubygems/core_ext/kernel_require.rb>:37:in 'Kernel#require'
/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.4.7/lib/ruby/gems/3.4.0/gems/bootsnap-1.18.6/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in 'Kernel#require'
/opt/homebrew/Library/Homebrew/utils.rb:17:in 'block in Homebrew.require?'
/opt/homebrew/Library/Homebrew/warnings.rb:29:in 'Warnings.ignore'
/opt/homebrew/Library/Homebrew/utils.rb:16:in 'Homebrew.require?'
/opt/homebrew/Library/Homebrew/brew.rb:116:in '<main>'
If reporting this issue please do so at (not Homebrew/* repositories):
  https://github.com/buo/homebrew-cask-upgrade/issues/new

Not sure if that's only me or others have the same issue as well.

[Mick235711]

Hmm, not really sure what had happened, this PR does not touch the mas_load_outdated function...
What is the output from mas outdated? Perhaps the format was changed for some reason.

[ondrejfuhrer]

Hmm, not really sure what had happened, this PR does not touch the mas_load_outdated function... What is the output from mas outdated? Perhaps the format was changed for some reason.

I think I figured it out and pushed change to your branch (hope that's ok 🙂 ). I'll merge once the CI passes.

[Mick235711]

Yeah, that's fine. Thanks a lot for the helping hand!