Conversation
When running Zeus commands from AI tools or piped contexts, the client auto-detects TTY from stdout, which causes commands to get socket pairs instead of PTYs. This adds explicit flags to override TTY detection: - --tty / -t: force PTY allocation (like ssh -t) - --no-tty / -T: force socket pairs (like ssh -T) - Default (auto): existing behavior, detect from fd Also fixes sync.WaitGroup pass-by-value bug in forwardOutput and guards MirrorWinsize call with a terminal check.
Several fixes to make zeus work when invoked from piped contexts (e.g. Claude Code which redirects stdin from /dev/null): - Close remote fd copies immediately after sending to server, not via defer -- prevents fd leak that blocks EOF on local ends - Remove broken sync.WaitGroup (was pass-by-value and Add inside goroutine, effectively dead code) -- exit status read from the unix socket is the real synchronization point - Shutdown write side of socket on stdin EOF so command process gets EOF instead of blocking forever on stdin reads - Do not SIGKILL command after receiving exit status -- with socket pairs Ruby uses full buffering, and killing the process before it flushes loses all output - Guard MirrorWinsize with IsTerminal check - Bump version to 0.19.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.