Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

added Gson runtime#32

Merged
iconara merged 9 commits into
burtcorp:masterfrom
linehrr:master
May 6, 2018
Merged

added Gson runtime#32
iconara merged 9 commits into
burtcorp:masterfrom
linehrr:master

Conversation

@linehrr

@linehrr linehrr commented Apr 30, 2018

Copy link
Copy Markdown
Contributor

Changes to be committed:
new file: jmespath-gson/pom.xml
new file: jmespath-gson/src/main/java/io/burt/jmespath/gson/GsonRuntime.java
new file: jmespath-gson/src/test/java/io/burt/jmespath/gson/GsonComplianceTest.java
new file: jmespath-gson/src/test/java/io/burt/jmespath/gson/GsonTest.java
modified: pom.xml

linehrr added 4 commits April 30, 2018 11:59
 Changes to be committed:
	new file:   jmespath-gson/pom.xml
	new file:   jmespath-gson/src/main/java/io/burt/jmespath/gson/GsonRuntime.java
	new file:   jmespath-gson/src/test/java/io/burt/jmespath/gson/GsonComplianceTest.java
	new file:   jmespath-gson/src/test/java/io/burt/jmespath/gson/GsonTest.java
	modified:   pom.xml
 Changes to be committed:
	modified:   jmespath-gson/src/main/java/io/burt/jmespath/gson/GsonRuntime.java
 Changes to be committed:
	modified:   jmespath-gson/src/main/java/io/burt/jmespath/gson/GsonRuntime.java
 Changes to be committed:
	modified:   jmespath-gson/src/main/java/io/burt/jmespath/gson/GsonRuntime.java
@linehrr linehrr mentioned this pull request Apr 30, 2018
@linehrr

linehrr commented May 1, 2018

Copy link
Copy Markdown
Contributor Author

looks like Travis test process is broken?

mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V
The JAVA_HOME environment variable is not defined correctly
This environment variable is needed to run this program
NB: JAVA_HOME should point to a JDK not a JRE
The command "eval mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V " failed. Retrying, 2 of 3.

@iconara

iconara commented May 1, 2018

Copy link
Copy Markdown
Collaborator

Thank you for the PR @linehrr. I haven't had time to go through it yet, but it seems like the Travis build is broken, yes. It's probably something that Travis has changed the last year that is acting up, they're not the best keeping things backwards compatible (but hey, it's free so I'm not complaining really). If you can figure it out that would be very helpful.

 Changes to be committed:
	modified:   .travis.yml
@linehrr

linehrr commented May 1, 2018

Copy link
Copy Markdown
Contributor Author

@iconara
solved.
it's the jdk version defined in travis.yml.
now Travis only supports jdk1.8, so we just need to adjust the jdk version.
I've submitted the change, debugging some failed tests now.

linehrr added 2 commits May 1, 2018 14:24
 Changes to be committed:
	modified:   jmespath-gson/src/main/java/io/burt/jmespath/gson/GsonRuntime.java
 Changes to be committed:
	modified:   jmespath-gson/src/main/java/io/burt/jmespath/gson/GsonRuntime.java
@iconara

iconara commented May 1, 2018

Copy link
Copy Markdown
Collaborator

Excellent, thank you. I will try to get some time to look at this more closely. Could you describe a little bit more what it is that you have done, is this just the dump #29 made into a PR, or have you done anything else?

linehrr added 2 commits May 1, 2018 14:58
 Changes to be committed:
	modified:   jmespath-gson/src/main/java/io/burt/jmespath/gson/GsonRuntime.java
 Changes to be committed:
	modified:   jmespath-gson/src/main/java/io/burt/jmespath/gson/GsonRuntime.java
@linehrr

linehrr commented May 1, 2018

Copy link
Copy Markdown
Contributor Author

@iconara
ok all tests passed.
what I have done:

  1. added Gson runtime.
  2. fixed travis.yml file to upgrade jdk from 1.7 to 1.8.

that's about it, no touch to the core.

@linehrr

linehrr commented May 4, 2018

Copy link
Copy Markdown
Contributor Author

@iconara can you please review this PR and hopefully make it into release 0.2.1?
that way our project can move over to 0.2.1 and don't have to deal with the Gson Jackson conversion headache. thanks !

@iconara iconara merged commit 7a9694b into burtcorp:master May 6, 2018
@iconara

iconara commented May 6, 2018

Copy link
Copy Markdown
Collaborator

This was released in jmespath-0.2.1.

@linehrr there is also a jmespath-0.3.0-SNAPSHOT which was what I meant to release, but Maven is not my strongest suit. That release includes another improvement, but if you have custom functions you will have to change your code slightly (very slightly). As soon as you tell me that release works for you I will release a non-snapshot version.

Thank you for getting the Gson and for your help getting the Travis config up to date again.

@linehrr

linehrr commented May 6, 2018

Copy link
Copy Markdown
Contributor Author

@iconara we don't have any custom UDF. so I think you can go ahead and release it.
since it's 0.3.0, it's not meant to be backward compatible.
so we should be fine here. (0.2.1 might be broken since we introduced back-breaking code inside, in theory it should be backward compatible with 0.2.x)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants