186055022 & 186034612 common sensor refactor & modulizations - #102
Merged
Conversation
YaokunLin
changed the title
monicakochofar
approved these changes
Oct 10, 2023
monicakochofar
left a comment
monicakochofar
left a comment
Contributor
There was a problem hiding this comment.
LGTM on frontend side!
BallardRobinett
approved these changes
Oct 10, 2023
BallardRobinett
left a comment
BallardRobinett
left a comment
Contributor
There was a problem hiding this comment.
Looking much cleaner now and working on my local, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/n/projects/2667313/stories/186055022
https://www.pivotaltracker.com/n/projects/2667313/stories/186034612