Fixed a memory leak in ItemMeasurer#239
Merged
Merged
Conversation
If the resulting ref was null, the old reference wasn't getting reset, and we'd end up re-observing the original node.
bvaughn
reviewed
May 27, 2019
| this._didProvideValidRef = true; | ||
| this._node = ref; | ||
| } else if (ref !== null) { | ||
| } else if (ref) { |
Owner
There was a problem hiding this comment.
Why this change? Seems like ref !== null should still be valid?
Owner
|
Cool, I dig it. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed memory was ballooning over time in an app I'm working on; fired up the Chromium profiler and took some heap dumps, noticed tons of
ResizeObserverreferences that were not eligible for GC. Eventually traced it back to this.If the resulting ref was null in
_refSetter(), the old reference wasn't getting reset, and we'd end up re-observing the original, stale node. This seems to have been preventing garbage collection.After making this change, memory usage seems stable.