This repository was archived by the owner on Jun 26, 2020. It is now read-only.
[codegen] Fold uextend.i64.i32 into a no-op whenever possible on x86#845
Closed
bnjbvr wants to merge 1 commit into
Closed
[codegen] Fold uextend.i64.i32 into a no-op whenever possible on x86#845bnjbvr wants to merge 1 commit into
bnjbvr wants to merge 1 commit into
Conversation
Collaborator
|
This is a fine stopgap solution. In general however we want something table-driven (ie a machine-generated automaton) that runs during machine code generation and acts on the actual encodings emitted. Such an automaton can likely subsume other optimizations, eg the shrinking pass. |
Member
Author
|
I'll need to re-work this a bit, and think about it (maybe publicly as part of an issue). Closing since there are no good reasons to keep this WIP PR open for too long. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still a WIP. This removes spurious moves (generated by uextend.i64.i32) whenever the previous instruction did zero the upper 32 bits for us.
Remaining things to do:
nullrecipe being not satisfied.