This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Add flags to allow SIMD instructions#910
Merged
Merged
Conversation
sunfishcode
reviewed
Aug 26, 2019
| Arg::with_name("enable-simd") | ||
| .long("enable-simd") | ||
| .help("Enable SIMD operations") | ||
| } |
Member
There was a problem hiding this comment.
Is this different from --set=enable_simd=true?
Member
Author
There was a problem hiding this comment.
--set=enable_simd=true will set the flags for the TargetIsa whereas this one is used for telling wabt that we want to parse WASM and not fail on SIMD operators.
Member
There was a problem hiding this comment.
Oh, of course. Maybe the string could say "Enable wasm SIMD operations" then?
sunfishcode
approved these changes
Aug 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing out the SIMD instructions I have implemented in https://github.com/abrown/cranelift/tree/work-ahead I discovered that I needed:
wabtthat SIMD instructions are allowed--this requires updatingwabt-rsso we can passFeatures--enable-simdflag onclif-util wasmto allow me to set the allowed features