This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Switch from mmap to memmap to support Windows#940
Merged
Conversation
bnjbvr
approved these changes
Aug 26, 2019
bnjbvr
left a comment
bnjbvr
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks! (just waiting on CI to pass before merging)
bjorn3
suggested changes
Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#890 introduced a dependency on the
mmapcrate, which doesn't support Windows. A quick investigation showed mmap is not actively maintained, so people mostly use thememmapcrate. This PR switches to that, and seems to work without issues.