This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Support running spec tests in wasmtime#992
Merged
Merged
Conversation
abrown
commented
Sep 6, 2019
bnjbvr
reviewed
Sep 9, 2019
abrown
force-pushed
the
spec-tests-in-wasmtime
branch
3 times, most recently
from
53d3c70 to
ee4f313
Compare
Member
Author
|
With these changes and #993 to avoid a test failure in |
bnjbvr
suggested changes
Sep 17, 2019
abrown
force-pushed
the
spec-tests-in-wasmtime
branch
from
decd685 to
4f3b209
Compare
bnjbvr
approved these changes
Sep 19, 2019
bnjbvr
left a comment
bnjbvr
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks! Can you fold the last commit with the one that introduces encodings for SIMD iadd, before merging, please?
abrown
force-pushed
the
spec-tests-in-wasmtime
branch
from
4f3b209 to
b78b15e
Compare
This was referenced Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support running spec tests in wasmtime, I had to modify cranelift with the following commits. This is a non-exhaustive list since some spec tests are currently failing and will likely require further changes.