Skip to content

Support wasm32-unknown-wasi and x86_64-apple-macosx10.7.0#14

Merged
sunfishcode merged 5 commits into
bytecodealliance:masterfrom
bjorn3:patch-1
Jul 9, 2019
Merged

Support wasm32-unknown-wasi and x86_64-apple-macosx10.7.0#14
sunfishcode merged 5 commits into
bytecodealliance:masterfrom
bjorn3:patch-1

Conversation

@bjorn3

@bjorn3 bjorn3 commented May 11, 2019

Copy link
Copy Markdown
Contributor

No description provided.

bjorn3 added a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request May 11, 2019
Comment thread src/targets.rs Outdated
@sunfishcode

Copy link
Copy Markdown
Member

Also, we should teach Triple::default_calling_convention about Wasi. We can either use SystemV or make a new Wasm calling convention.

@bjorn3 bjorn3 changed the title Support wasm32-unknown-wasi Support wasm32-unknown-wasi and x86_64-apple-macosx10.7.0 Jun 23, 2019
@bjorn3

bjorn3 commented Jun 23, 2019

Copy link
Copy Markdown
Contributor Author

I added support for triples like x86_64-apple-macosx10.7.0, which rustc uses as llvm triple since rust-lang/rust#60788. I currently workaround this in cg_clif by replacing triples starting with x86_64-apple-macosx with x86_64-apple-darwin.

@bnjbvr bnjbvr requested a review from sunfishcode June 24, 2019 16:11
Comment thread src/targets.rs
Comment thread src/targets.rs
@bnjbvr bnjbvr requested a review from sunfishcode July 8, 2019 13:25

@sunfishcode sunfishcode left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@sunfishcode sunfishcode merged commit fd21542 into bytecodealliance:master Jul 9, 2019
@bjorn3 bjorn3 deleted the patch-1 branch July 9, 2019 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants