Enable semver-compatible matching of import/export lookups in targets #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibonacci1729
force-pushed
the
targets-semver
branch
from
9a0787b to
56011fa
Compare
Collaborator
Author
|
Switching to draft until I finish up the test. |
Member
|
Seems like a reasonable starting point to me yeah 👍 |
fibonacci1729
force-pushed
the
targets-semver
branch
from
56011fa to
d7159d0
Compare
fibonacci1729
force-pushed
the
targets-semver
branch
from
d7159d0 to
83e1284
Compare
…validation Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
fibonacci1729
force-pushed
the
targets-semver
branch
from
83e1284 to
0539c3b
Compare
calvinrp
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in targets validation the lookup of imports/exports required an exact match. This PR switches to using a NameMap that enables semver-compatible matching lookups.
NOTE: This PR borrows the implementation of NameMap from wasmtime.
As a follow up i'd like to re-use this NameMap to consolidate semver-compatible imports/exports during encoding so that only the maximal semver-compatible range is used.