Skip to content

Create a placeholder for WASI threads implementation#1783

Merged
wenyongh merged 1 commit into
bytecodealliance:dev/wasi_threadsfrom
loganek:loganek/threads-placeholder
Dec 6, 2022
Merged

Create a placeholder for WASI threads implementation#1783
wenyongh merged 1 commit into
bytecodealliance:dev/wasi_threadsfrom
loganek:loganek/threads-placeholder

Conversation

@loganek
Copy link
Copy Markdown
Contributor

@loganek loganek commented Dec 5, 2022

This a simpler version of the PR: #1638
To simplify the review, I'll split it into a few smaller changes, starting from this one, which just creates a function stub and a simplistic example.

@loganek loganek force-pushed the loganek/threads-placeholder branch 2 times, most recently from 9574bd4 to 3becdff Compare December 5, 2022 17:46
@yamt
Copy link
Copy Markdown
Contributor

yamt commented Dec 6, 2022

This a simpler version of the PR: #1638 To simplify the review, I'll split it into a few smaller changes, starting from this one, which just creates a function stub and a simplistic example.

i feel the original version is simple enough.

@loganek
Copy link
Copy Markdown
Contributor Author

loganek commented Dec 6, 2022

@yamt it is indeed, but it's also a bit incorrect, and I'm not happy about the quality of that at all - I only made a PR to save my work and give others opportunity to provide higher-level feedback; I actually never intended to merge it as-it-is. As I came back to that work, I thought I'd use it as opportunity to split it into two separate PRs, where the first one is just to provide a template, and the second will be about the actual implementation (with some TODOs, which we address later on - that's why the development will happen on the dev/wasi_threads branch until we're fully ready). Having said that, many thanks for all your comments in the previous PR, I'll take them into account.

@loganek loganek force-pushed the loganek/threads-placeholder branch from 3becdff to 6933505 Compare December 6, 2022 09:25
@wenyongh wenyongh deleted the branch bytecodealliance:dev/wasi_threads December 6, 2022 09:34
@wenyongh wenyongh closed this Dec 6, 2022
@wenyongh wenyongh reopened this Dec 6, 2022
@loganek loganek force-pushed the loganek/threads-placeholder branch from 6933505 to 41959d6 Compare December 6, 2022 09:51
@loganek loganek force-pushed the loganek/threads-placeholder branch from 41959d6 to 4ce516e Compare December 6, 2022 10:11
Comment thread core/iwasm/common/wasm_native.c
Comment thread samples/wasi-threads/wasm-apps/CMakeLists.txt
Comment thread samples/wasi-threads/wasm-apps/no_pthread.c
@loganek loganek force-pushed the loganek/threads-placeholder branch from 4ce516e to 478920c Compare December 6, 2022 11:23
Copy link
Copy Markdown
Collaborator

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 684ae65 into bytecodealliance:dev/wasi_threads Dec 6, 2022
@loganek loganek mentioned this pull request Dec 7, 2022
19 tasks
eloparco pushed a commit to eloparco/wasm-micro-runtime that referenced this pull request Dec 11, 2022
vickiegpt pushed a commit to vickiegpt/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@loganek loganek deleted the loganek/threads-placeholder branch June 10, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants