Use wasi-sdk 20 pre-release for tests with threads#2021
Conversation
|
I opened an issue for the wasi-sdk problem on Ubuntu 20.04 WebAssembly/wasi-sdk#303 |
| test: | ||
| needs: [build_iwasm, build_llvm_libraries_on_ubuntu_2004, build_wamrc] | ||
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
It may be a risk to upgrade the default test OS to Ubuntu-22.04. Maybe we can keep this PR open, and wait until the wasi-sdk-20.0 for threads works for Ubuntu-20.04?
There was a problem hiding this comment.
No strong opinion, let's wait for the decision on the issue I opened. Or, as an alternative, we could run those tests both with 20.04 and 22.04.
There was a problem hiding this comment.
What's the risk? In WebAssembly/wasi-sdk#303, I mentioned that I wouldn't mind if someone else (@eloparco?) works on getting wasi-sdk to build on older machines but I wasn't personally too interested. If this workflow is the only reason to do so, I wonder if we could resolve whatever risks are here? I assume this workflow would have to be updated at some point anyways since I wouldn't assume it to pin to 20.04 forever.
There was a problem hiding this comment.
I was just worried about the spec cases and wasi-threads cases are not tested on Ubuntu-20.04, and we don't know whether there are errors reported on it. I discussed with @lum1n0us, he also agreed to run these tests on both Ubuntu-20.04 and Ubuntu-22.04, it seems better. So @eloparco, could you help enable that?
eloparco
force-pushed
the
eloparco/wasi-sdk-20-pre-release
branch
5 times, most recently
from
661e246 to
04248f1
Compare
eloparco
force-pushed
the
eloparco/wasi-sdk-20-pre-release
branch
from
04248f1 to
83de516
Compare
| 8f5275796a82f8ecfd0833a4f3f444fa37ed4546 | ||
| git checkout FETCH_HEAD | ||
| make -j \ | ||
| make \ |
There was a problem hiding this comment.
Using make -j can speed up the build process, did you find error when building with -j flag?
There was a problem hiding this comment.
I must have removed it by mistake, I put it back. The multi-tier-jit test is failing in the CI, it doesn't look related with this PR.
eloparco
force-pushed
the
eloparco/wasi-sdk-20-pre-release
branch
from
83de516 to
13842aa
Compare
eloparco
force-pushed
the
eloparco/wasi-sdk-20-pre-release
branch
from
13842aa to
5c12253
Compare
wasi-sdk-20 supports older versions of glibc and allow us to use it in the CI with Ubuntu 20.04. Refer to https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-20 And #2021 for previous upgrade to wasi-sdk-20 pre-release.
…2021) `wasi-sdk-20` pre-release can be used to avoid building `wasi-libc` to enable threads. It's not possible to use `wasi-sdk-20` pre-release on Ubuntu 20.04 because of incompatibility with the glibc version: ```bash /opt/wasi-sdk/bin/clang: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /opt/wasi-sdk/bin/clang) ```
) wasi-sdk-20 supports older versions of glibc and allow us to use it in the CI with Ubuntu 20.04. Refer to https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-20 And bytecodealliance#2021 for previous upgrade to wasi-sdk-20 pre-release.
3 participants
wasi-sdk-20pre-release can be used to avoid buildingwasi-libcto enable threads.It's not possible to use
wasi-sdk-20pre-release on Ubuntu 20.04 because of incompatibility with the glibc version: