Skip to content

GC: wasmparser: Fix gc/gc-ref.wat roundtrip test#1062

Merged
fitzgen merged 1 commit into
bytecodealliance:mainfrom
imikushin:enable-gc-ref-test
Jul 11, 2023
Merged

GC: wasmparser: Fix gc/gc-ref.wat roundtrip test#1062
fitzgen merged 1 commit into
bytecodealliance:mainfrom
imikushin:enable-gc-ref-test

Conversation

@imikushin

Copy link
Copy Markdown
Contributor

Fix gc/gc-ref.wat roundtrip test.

Requires #1059.

@fitzgen

fitzgen commented Jun 14, 2023

Copy link
Copy Markdown
Member

It seems like the gc-ref.wat test is still failing in CI: https://github.com/bytecodealliance/wasm-tools/actions/runs/5248728965/jobs/9480613647?pr=1062#step:4:629


failed test: tests/local/gc/gc-ref.wat

Caused by:
    0: failed testing the binary output of `wat`
    1: wasm isn't valid
    2: type mismatch: expected (ref $type), found (ref $type) (at offset 0x6b)

@fitzgen

fitzgen commented Jun 14, 2023

Copy link
Copy Markdown
Member

Ah I see this is built on top of the other PR, nevermind.

@imikushin

Copy link
Copy Markdown
Contributor Author

Ah I see this is built on top of the other PR, nevermind.

Yep.

@imikushin imikushin marked this pull request as ready for review July 10, 2023 23:29
@imikushin

Copy link
Copy Markdown
Contributor Author

Now that #1059 is merged, this should successfully pass CI.
cc @fitzgen

@imikushin imikushin force-pushed the enable-gc-ref-test branch from 053c01b to 72e29f3 Compare July 10, 2023 23:34
@imikushin

Copy link
Copy Markdown
Contributor Author

Rebased on top of latest main. Should be ready to merge.

@fitzgen fitzgen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen merged commit ed1b51b into bytecodealliance:main Jul 11, 2023
@imikushin imikushin deleted the enable-gc-ref-test branch July 12, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants