Skip to content

Extern define#228

Merged
peterhuene merged 2 commits into
bytecodealliance:mainfrom
martindevans:extern-define
Mar 2, 2023
Merged

Extern define#228
peterhuene merged 2 commits into
bytecodealliance:mainfrom
martindevans:extern-define

Conversation

@martindevans
Copy link
Copy Markdown
Contributor

  • Added public Define methods for all externs.
  • Removed method which accepted an object parameter and dynamically checked that it was an extern.

As discussed in #224 (comment)

 - Removed method which accepted an `object` parameter and dynamically checked that it was an extern.
Copy link
Copy Markdown
Member

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@peterhuene peterhuene merged commit 1aac330 into bytecodealliance:main Mar 2, 2023
@martindevans martindevans deleted the extern-define branch March 2, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants