Function Wrapper Cache#236
Merged
peterhuene merged 5 commits intoApr 21, 2023
Merged
Conversation
…s Wrap to be called multiple times without lots of allocations of the same thing.
Merged
…d (one less allocation in the cached path).
kpreisser
reviewed
Apr 3, 2023
Co-authored-by: Konstantin Preißer <kpreisser@users.noreply.github.com>
kpreisser
approved these changes
Apr 11, 2023
Contributor
kpreisser
left a comment
kpreisser
left a comment
There was a problem hiding this comment.
Looks good to me! Can you rebuild the project in order to regenerate Function.Wrap.cs, and commit it? (As my suggestion commit only modified Function.Wrap.tt.)
Thanks!
Contributor
Author
|
I've regenerated that file and pushed it 👍 |
peterhuene
approved these changes
Apr 21, 2023
Member
peterhuene
left a comment
peterhuene
left a comment
There was a problem hiding this comment.
Sorry for the delay in reviewing this. Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a cache to
Functionwhich stores wrapped function. This allows Wrap to be called multiple times without lots of allocations of the same thing.This will work well with #235 - a
Callercan ask for aFunctionobject (cached) and then wrap it (cached) and then call it, all without allocating anything 🥳