Skip to content

Delete an unused field in GuestTask #12545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fitzgen merged 1 commit into from
Feb 9, 2026
Merged

Delete an unused field in GuestTask #12545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions crates/wasmtime/src/runtime/component/concurrent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ use std::vec::Vec;
use table::{TableDebug, TableId};
use wasmtime_environ::Trap;
use wasmtime_environ::component::{
CanonicalAbiInfo, CanonicalOptions, CanonicalOptionsDataModel, ExportIndex, MAX_FLAT_PARAMS,
CanonicalAbiInfo, CanonicalOptions, CanonicalOptionsDataModel, MAX_FLAT_PARAMS,
MAX_FLAT_RESULTS, OptionsIndex, PREPARE_ASYNC_NO_RESULT, PREPARE_ASYNC_WITH_RESULT,
RuntimeComponentInstanceIndex, RuntimeTableIndex, StringEncoding,
TypeComponentGlobalErrorContextTableIndex, TypeComponentLocalErrorContextTableIndex,
Expand Down Expand Up @@ -4369,8 +4369,6 @@ pub(crate) struct GuestTask {
/// If present, a pending `Event::None` or `Event::Cancelled` to be
/// delivered to this task.
event: Option<Event>,
/// The `ExportIndex` of the guest function being called, if known.
function_index: Option<ExportIndex>,
/// Whether or not the task has exited.
exited: bool,
/// Threads belonging to this task
Expand Down Expand Up @@ -4455,7 +4453,6 @@ impl GuestTask {
sync_call_set,
instance,
event: None,
function_index: None,
exited: false,
threads: HashSet::new(),
host_future_state,
Expand Down Expand Up @@ -5169,7 +5166,7 @@ pub(crate) fn prepare_call<T, R>(
let (exit_tx, exit_rx) = oneshot::channel();

let caller = state.guest_thread;
let mut task = GuestTask::new(
let task = GuestTask::new(
state,
Box::new(for_any_lower(move |store, params| {
lower_params(handle, token.as_context_mut(store), params)
Expand Down Expand Up @@ -5204,7 +5201,6 @@ pub(crate) fn prepare_call<T, R>(
},
async_function,
)?;
task.function_index = Some(handle.index());

let task = state.push(task)?;
let thread = state.push(GuestThread::new_implicit(task))?;
Expand Down
5 changes: 0 additions & 5 deletions crates/wasmtime/src/runtime/component/func.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,11 +825,6 @@ impl Func {
self.instance
}

#[cfg(feature = "component-model-async")]
pub(crate) fn index(self) -> ExportIndex {
self.index
}

/// Creates a `LowerContext` using the configuration values of this lifted
/// function.
///
Expand Down