Consolidate component-related store data - #12549
Merged
alexcrichton merged 1 commit intoFeb 9, 2026
Merged
Conversation
fitzgen
approved these changes
Feb 9, 2026
Instead of having `#[cfg]` within `store.rs` move it all to `component/store.rs` to cut down on `#[cfg]`. It's a bit awkward in some places trying to borrow a bunch of fields at once, but it's not the end of the world.
alexcrichton
force-pushed
the
consolidate-component-store-data
branch
from
February 9, 2026 20:43
1aecaa0 to
8dccf00
Compare
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 9, 2026
Instead of having `#[cfg]` within `store.rs` move it all to `component/store.rs` to cut down on `#[cfg]`. It's a bit awkward in some places trying to borrow a bunch of fields at once, but it's not the end of the world.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having
#[cfg]withinstore.rsmove it all tocomponent/store.rsto cut down on#[cfg]. It's a bit awkward in someplaces trying to borrow a bunch of fields at once, but it's not the end
of the world.
Depends on #12546