Respect signals-based-traps in component trampolines - #12626
Merged
fitzgen merged 1 commit intoFeb 20, 2026
Conversation
This commit fixes a regression from bytecodealliance#12547 where traps happening in component trampolines weren't respecting the signals-based-traps configuration of the `Engine` meaning that native CLIF traps could be executed in environments which weren't configured to catch it. This refactors the implementation internally to share more code with `FuncEnvironment` through some traits to ensure that the same knobs and plumbing are used to translate traps.
fitzgen
approved these changes
Feb 20, 2026
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Feb 23, 2026
Fixes a typo from bytecodealliance#12626
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 23, 2026
Fixes a typo from #12626
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a regression from #12547 where traps happening in component trampolines weren't respecting the signals-based-traps configuration of the
Enginemeaning that native CLIF traps could be executed in environments which weren't configured to catch it. This refactors the implementation internally to share more code withFuncEnvironmentthrough some traits to ensure that the same knobs and plumbing are used to translate traps.