Make serde an optional dependency in wasmtime-core - #12739
Merged
alexcrichton merged 1 commit intoMar 9, 2026
Conversation
cg_clif does not need serde, yet it was previously pulled in by Cranelift through the dependency on wasmtime-core.
github-actions
Bot
added
fuzzing
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "fuzzing", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
alexcrichton
approved these changes
Mar 9, 2026
alexcrichton
left a comment
alexcrichton
left a comment
Member
There was a problem hiding this comment.
Thanks! Can you ensure there's a cargo check on CI for with/without the feature, too? (or maybe there is already?)
Contributor
Author
|
It should already be checked in CI through |
bjorn3
added a commit
to bjorn3/wasmtime
that referenced
this pull request
Mar 10, 2026
…12739) cg_clif does not need serde, yet it was previously pulled in by Cranelift through the dependency on wasmtime-core.
alexcrichton
pushed a commit
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cg_clif does not need serde, yet it was previously pulled in by Cranelift through the dependency on wasmtime-core.
Fixes #12733