Skip to content

Cranelift: implicitly consider trapping blocks as "cold" during lowering#13689

Merged
fitzgen merged 2 commits into
bytecodealliance:mainfrom
fitzgen:trap-blocks-are-cold
Jun 18, 2026
Merged

Cranelift: implicitly consider trapping blocks as "cold" during lowering#13689
fitzgen merged 2 commits into
bytecodealliance:mainfrom
fitzgen:trap-blocks-are-cold

Conversation

@fitzgen

@fitzgen fitzgen commented Jun 18, 2026

Copy link
Copy Markdown
Member

These blocks cannot be part of hot loops, as they terminate control.

These blocks cannot be part of hot loops, as they terminate control.
@fitzgen fitzgen requested review from a team as code owners June 18, 2026 15:58
@fitzgen fitzgen requested review from cfallin and removed request for a team June 18, 2026 15:58
Comment thread cranelift/codegen/src/machinst/blockorder.rs Outdated
@github-actions github-actions Bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. labels Jun 18, 2026
@fitzgen fitzgen enabled auto-merge June 18, 2026 20:36
@fitzgen fitzgen added this pull request to the merge queue Jun 18, 2026
Merged via the queue into bytecodealliance:main with commit d95a3ec Jun 18, 2026
52 checks passed
@fitzgen fitzgen deleted the trap-blocks-are-cold branch June 18, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift Issues related to the Cranelift code generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants