machinst x64: heuristic to determine which operand should be the read-only one#2283
Closed
bnjbvr wants to merge 3 commits into
Closed
machinst x64: heuristic to determine which operand should be the read-only one#2283bnjbvr wants to merge 3 commits into
bnjbvr wants to merge 3 commits into
Conversation
…nce of a uextend;
…ds of commutative ops;
github-actions
Bot
added
cranelift
Member
Author
|
Probably irrelevant in an ISLE world. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is split off #2277 (one commit on top of the two others) because it doesn't work as good as expected on simple test cases; i think the estimated use count should be taken into account first, before we use the vreg id heuristic. Also, we could use a better heuristic. Leaving the PR here in case somebody wants to pick it up.
cc @julian-seward1 @cfallin