Produce an error at runtime rather than at compile time for unsupport…#5627
Merged
cfallin merged 1 commit intobytecodealliance:mainfrom Jan 24, 2023
Merged
Conversation
…ed architectures in cranelift-native
github-actions
bot
added
the
cranelift
bjorn3
force-pushed
the
cranelift-native-x86
branch
from
d59600d to
69dd38f
Compare
cfallin
approved these changes
Jan 24, 2023
Contributor
Author
|
Would a patch release for cranelift-native be possible or should I vendor it for the time being? |
Member
|
I think this probably doesn't meet the bar for a patch release (unsupported platform, no functional correctness issue, just ergonomics around how to fail cleanly); probably best to vendor, sorry! It'll go out with the 6.0 release on Feb 20. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ed architectures in cranelift-native