-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add a script to vendor WIT files #8111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexcrichton
merged 2 commits into
bytecodealliance:main
from
alexcrichton:ci-vendor-wits
Mar 13, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| #!/bin/sh | ||
|
|
||
| # Script to re-vendor the WIT files that Wasmtime uses as defined by a | ||
| # particular tag in upstream repositories. | ||
| # | ||
| # This script is executed on CI to ensure that everything is up-to-date. | ||
|
|
||
| # Space-separated list of wasi proposals that are vendored here along with the | ||
| # tag that they're all vendored at. | ||
| # | ||
| # This assumes that the repositories all have the pattern: | ||
| # https://github.com/WebAssembly/wasi-$repo | ||
| # and every repository has a tag `v$tag` here. That is currently done as part | ||
| # of the WASI release process. | ||
| repos="cli clocks filesystem http io random sockets" | ||
| tag=0.2.0 | ||
|
|
||
| set -ex | ||
|
|
||
| dst=crates/wasi/wit/deps | ||
|
|
||
| rm -rf $dst | ||
| mkdir -p $dst | ||
|
|
||
| for repo in $repos; do | ||
| mkdir $dst/$repo | ||
| curl -L https://github.com/WebAssembly/wasi-$repo/archive/refs/tags/v$tag.tar.gz | \ | ||
| tar xzf - --strip-components=2 -C $dst/$repo wasi-$repo-$tag/wit | ||
| rm -rf $dst/$repo/deps* | ||
| done | ||
|
|
||
| rm -rf crates/wasi-http/wit/deps | ||
| cp -r $dst crates/wasi-http/wit | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe check
git diff --exit-codebefore this and exit the script before doing any permanent deletions if there are local, uncommitted changes? Just to be safe.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I'd prefer to leave that to CI because it makes editing a script like this hard to work with and git is otherwise pretty good about making sure things aren't overwritten.