Upgrade to wasm-tools 211 and wasmtime 21#978
Merged
Conversation
in wasmtime 21, component::bindgen stopped making import functions trappable unless you ask for them specifically, which is a great idea and I totally missed it when it landed. Lots of text diff but ultimately getting rid of the totally-unused ability to trap in import functions.
alexcrichton
approved these changes
Jun 19, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wasm-tools upgrade is pretty benign: wit-bindgen's parse deals in groups of packages now, rather than a single package.
The wasmtime upgrade has lots of text diff but ultimately the principle is simple: by default, wasmtime::component::bindgen no longer makes import funcs trappable.