Skip to content

test converting invalid#4

Open
c2thorn wants to merge 1 commit intorewrite-test-basefrom
rewrite-test-invalid
Open

test converting invalid#4
c2thorn wants to merge 1 commit intorewrite-test-basefrom
rewrite-test-invalid

Conversation

@c2thorn
Copy link
Copy Markdown
Owner

@c2thorn c2thorn commented Sep 11, 2024

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@c2thorn c2thorn changed the title test converting accessapproval test converting invalid Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant