Add username to the dashboard of who logged an incident or any incident updates. - #3809
Merged
Merged
Conversation
|
This doesn't work on v2.4, it just displays 'Posted 6 minutes ago by :username' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In relation to #3046 I've added the username of the person who logged an incident or an incident update on the dashboard.
I've only made the change in the English translation. I've noticed that viewing in other languages it still says "by {username}" - hopefully this is okay as I see some other languages aren't fully translated anyway.
I haven't added the name of the person to the notifications that go out as originally specified. I was wondering if that needed more thought? My only thinking is you may not want end users to know who posted it so they don't badger individuals in a company about an outage. I think it's good internally (on the dashboard) for accountability, but think end users perhaps may not need to know who. It may be better to make an option somewhere "Include username in notification emails" so the owner can decide.
Let me know if anything I've said doesn't make sense, or requires amending.