Skip to content

Add the ability to select a template when adding an incident. - #3815

Merged
jbrooksuk merged 2 commits into
cachethq:2.4from
Data-Kiss:templates-update-incident
Nov 2, 2019
Merged

Add the ability to select a template when adding an incident.#3815
jbrooksuk merged 2 commits into
cachethq:2.4from
Data-Kiss:templates-update-incident

Conversation

@Data-Kiss

Copy link
Copy Markdown
Contributor

Add the ability to select a template when adding an incident, as requested in #3566.

@accesslint accesslint Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

Comment thread resources/views/dashboard/incidents/updates/add.blade.php
Comment thread resources/views/dashboard/incidents/updates/add.blade.php
Comment thread resources/views/dashboard/incidents/updates/add.blade.php
Comment thread resources/views/dashboard/incidents/updates/add.blade.php
Comment thread resources/views/dashboard/incidents/updates/add.blade.php
@Data-Kiss

Copy link
Copy Markdown
Contributor Author

Note that the entire section in resources/assets/js/cachet.js was commented out for some reason. I uncommented it to make this build, so if anyone knows why it needs to be commented out let me know. All seems to be fine with it included.

@jbrooksuk
jbrooksuk merged commit e0df467 into cachethq:2.4 Nov 2, 2019
@welcome

welcome Bot commented Nov 2, 2019

Copy link
Copy Markdown

Hooray! Your first Pull Request was merged, here's to many more 馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants