Integration: git credentials - #329
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
secretspec | d0fbaca | Commit Preview URL Branch Preview URL |
Aug 13 2026, 12:35 PM |
|
This looks great. One UX change I would like before merging: make a small Git-specific At the moment the helper does: match &args.file {
Some(path) => Secrets::load_from(path),
None => Secrets::load(),
}I would prefer: match &args.file {
Some(path) => Secrets::load_from(path),
None => Secrets::load_embedded_git_credentials(),
}In particular, the helper should not walk the current directory when no file was selected. That makes the default deterministic for The embedded manifest would contain declarations, not values—something like an optional The resulting UX would be: $ secretspec git configure --url https://github.com --username USERwith no manifest path recorded. Advanced/custom setups would retain the current behavior: $ secretspec --file company-git.toml git configure \
--url https://github.com \
--token-secret GITHUB_TOKENBecause the helper is intentionally read-only, the embedded default also needs an explicit way to populate and remove its values, e.g. I would add coverage for both important cases: no |
|
One additional integration worth supporting is SMTP credentials for Git already uses the credential-helper protocol when See A minimal implementation could:
For example, the setup could look like: $ git config --global sendemail.smtpServer smtp.example.com
$ git config --global sendemail.smtpServerPort 587
$ git config --global sendemail.smtpEncryption tls
$ git config --global sendemail.smtpUser user@example.com
$ secretspec git configure --url smtp://smtp.example.com:587 --username user@example.com --global
$ secretspec git login smtp://smtp.example.com:587The explicit |
8456ed4 to
394c2ec
Compare
No description provided.