feat: New components for Workflow History V2 by adhityamamallan · Pull Request #1082 · cadence-workflow/cadence-web

adhityamamallan · 2025-11-17T14:45:21Z

Summary

Add new Workflow History V2 root component, which (for now) renders only a placeholder header component and placeholder tables.
Implement Workflow History Header with basic UI and sticky functionality
Add logic in WorkflowHistoryWrapper to render V2 UI based on feature flag

Test plan

Unit tests + ran locally.

Sticky header preview (with large content)

On narrow screens

Copilot

Pull Request Overview

This PR introduces a new workflow history header component (V2) as an alternative to the existing header, controlled by a feature flag HISTORY_PAGE_V2_ENABLED. The V2 header provides a simplified interface without the timeline chart functionality.

Key changes:

Added feature flag support to conditionally render either the V2 or original workflow history header
Created new WorkflowHistoryV2Header component with sticky header behavior and simplified UI
Added comprehensive test coverage for the new V2 header component

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/views/workflow-history/workflow-history.tsx	Implements feature flag logic to conditionally render V2 header or original header based on configuration
src/views/workflow-history/tests/workflow-history.test.tsx	Adds test infrastructure for feature flag testing including config API mock and V2 header mock
src/views/workflow-history-v2/workflow-history-header/workflow-history-header.types.ts	Defines TypeScript types for V2 header props including page filters and workflow history arguments
src/views/workflow-history-v2/workflow-history-header/workflow-history-header.tsx	Implements new V2 header component with sticky behavior, segmented control for view modes, and filter toggle
src/views/workflow-history-v2/workflow-history-header/workflow-history-header.styles.ts	Provides styled components and BaseUI overrides for V2 header with responsive design and sticky positioning
src/views/workflow-history-v2/workflow-history-header/tests/workflow-history-header.test.tsx	Comprehensive test suite covering V2 header rendering, interactions, sticky behavior, and filter toggling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/views/workflow-history-v2/workflow-history-header/workflow-history-header.styles.ts

...views/workflow-history-v2/workflow-history-header/__tests__/workflow-history-header.test.tsx

src/views/workflow-history-v2/workflow-history-header/workflow-history-header.tsx

src/views/workflow-history-v2/workflow-history-header/workflow-history-header.types.ts

src/views/workflow-history/__tests__/workflow-history.test.tsx

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

Copilot

Pull Request Overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/views/workflow-history/workflow-history-wrapper/__tests__/workflow-history-wrapper.test.tsx

src/views/workflow-history/__tests__/workflow-history.test.tsx

src/views/workflow-history-v2/workflow-history-header/workflow-history-header.tsx

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

Copilot

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/views/workflow-history-v2/workflow-history-v2.tsx

src/views/workflow-history-v2/workflow-history-header/workflow-history-header.tsx

src/views/workflow-history-v2/workflow-history-v2.tsx

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

src/views/workflow-history/workflow-history-wrapper/__tests__/workflow-history-wrapper.test.tsx

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

* Add new Workflow History V2 root component, which (for now) renders only a placeholder header component and placeholder tables. * Implement Workflow History Header with basic UI and sticky functionality * Add logic in WorkflowHistoryWrapper to render V2 UI based on feature flag Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

* Create fetcher utility Signed-off-by: Assem Hafez <assem.hafez@uber.com> * rename query Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Create hook for fetching history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * add configurable throttleMs to the hook Signed-off-by: Assem Hafez <assem.hafez@uber.com> * use fetcher in workflow history * remove useKeepLoadingEvents Signed-off-by: Assem Hafez <assem.hafez@uber.com> * grouping utility Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update test cases Signed-off-by: Assem Hafez <assem.hafez@uber.com> * change the api of onChange and add destroy method Signed-off-by: Assem Hafez <assem.hafez@uber.com> * replace getGroups with getState Signed-off-by: Assem Hafez <assem.hafez@uber.com> * init grouper hook Signed-off-by: Assem Hafez <assem.hafez@uber.com> * user grouper in history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update fetcher based on feedback Signed-off-by: Assem Hafez <assem.hafez@uber.com> * rename unmout to destroy Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Create hook for fetching history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * move condition into executeImmediately Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update destroy in method Signed-off-by: Assem Hafez <assem.hafez@uber.com> * mock grouper throttle Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix use fetcher test case Signed-off-by: Assem Hafez <assem.hafez@uber.com> * feat: Grouped events table header (#1059) * Grouped events header Signed-off-by: Assem Hafez <assem.hafez@uber.com> * add test cases Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix comment typo Signed-off-by: Assem Hafez <assem.hafez@uber.com> * add space for reset button Signed-off-by: Assem Hafez <assem.hafez@uber.com> * move grouped table Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Update src/views/workflow-history-v2/workflow-history-grouped-table/workflow-history-grouped-table.tsx Co-authored-by: Adhitya Mamallan <adi1998is@gmail.com> * Change Id to ID Signed-off-by: Assem Hafez <assem.hafez@uber.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> Co-authored-by: Adhitya Mamallan <adi1998is@gmail.com> * chore: Fixed docker URI for kafka image (#1066) Signed-off-by: Tim Chan <tim.chan@uber.com> * chore: New feature flag for Cron List View (#1068) Signed-off-by: Tim Chan <tim.chan@uber.com> * use fetcher in workflow history * fix content clicks Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix use initial selected event Signed-off-by: Assem Hafez <assem.hafez@uber.com> * increase page size Signed-off-by: Assem Hafez <assem.hafez@uber.com> * optimize first page processing Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix test cases Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix: History content negative z-index disallow clicks (#1069) * fix content clicks Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Update src/views/workflow-history/workflow-history.styles.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: Use fetcher in workflow history (#1064) * Create fetcher utility Signed-off-by: Assem Hafez <assem.hafez@uber.com> * rename query Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Create hook for fetching history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * add configurable throttleMs to the hook Signed-off-by: Assem Hafez <assem.hafez@uber.com> * use fetcher in workflow history * remove useKeepLoadingEvents Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update fetcher based on feedback Signed-off-by: Assem Hafez <assem.hafez@uber.com> * rename unmout to destroy Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Create hook for fetching history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * move condition into executeImmediately Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update destroy in method Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix type error with query params Signed-off-by: Assem Hafez <assem.hafez@uber.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix: Autocomplete for bool values (#1072) Fix workflows query autocomplete to suggest the correct tokens for boolean values Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * Add feature flag for Failover History (#1070) Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * Add failover history tab (#1071) Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * chore: Added ts-node to dev-deps (#1074) Signed-off-by: Tim Chan <tim.chan@uber.com> * feat: Hook to fetch & filter Failover History of a domain (#1075) Add hook for fetching and filtering failover history Add helper function to check if a ClusterFailover matches a given cluster attribute Add some types/constants for domain page failovers Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: New Cron Tab (#1078) Signed-off-by: Tim Chan <tim.chan@uber.com> * feat: Failover History table (#1076) * Add table to display failover history of a domain, with support for both active-passive and active-active domains Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: Fix console.error pollution (#1077) * chore: Fix console.error pollution Signed-off-by: Tim Chan <tim.chan@uber.com> * Relocated to src/test-utils. Signed-off-by: Tim Chan <tim.chan@uber.com> --------- Signed-off-by: Tim Chan <tim.chan@uber.com> * Add flag for History Page v2 (#1081) Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: Filters for Failover History Table (#1079) Add filters for Failover History table, but only for active-active domains Create filter for Cluster Attribute Scope, which depends on domain description to suggest possible scopes Create filter for Cluster Attribute Value, which depends on selected scope to suggest possible values/names Remove (now) unused styles file from DomainPageFailovers Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: Create a grouping utility that only parses new events (#1065) * grouping utility Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update test cases Signed-off-by: Assem Hafez <assem.hafez@uber.com> * change the api of onChange and add destroy method Signed-off-by: Assem Hafez <assem.hafez@uber.com> * replace getGroups with getState Signed-off-by: Assem Hafez <assem.hafez@uber.com> * call onchange after updating pending events Signed-off-by: Assem Hafez <assem.hafez@uber.com> * use sync processBatch for first page Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Update src/views/workflow-history/helpers/workflow-history-grouper.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply PR comments * Update src/views/workflow-history/helpers/workflow-history-grouper.types.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: Add modal to view full failover event (#1080) * Add modal for viewing an individual failover event, which is shown when "See more" in the table is clicked Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: New components for Workflow History V2 (#1082) * Add new Workflow History V2 root component, which (for now) renders only a placeholder header component and placeholder tables. * Implement Workflow History Header with basic UI and sticky functionality * Add logic in WorkflowHistoryWrapper to render V2 UI based on feature flag Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * update test cases * hook for history grouper * remove comments * fetcher updates * add placeholder for fetcher * update fetcher mock * fetcher start update * update todo * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix copilot comments * remove extra comment * lint fix * change lastFlattented initial value to -1 * remove unused import * address comments --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> Signed-off-by: Tim Chan <tim.chan@uber.com> Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> Co-authored-by: Adhitya Mamallan <adi1998is@gmail.com> Co-authored-by: Tim Chan <timothyc@alum.mit.edu> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

adhityamamallan force-pushed the history-header branch from 54163ef to 9661542 Compare November 17, 2025 14:46

adhityamamallan requested a review from Copilot November 17, 2025 14:46

Copilot started reviewing on behalf of adhityamamallan November 17, 2025 14:46 View session

Copilot finished reviewing on behalf of adhityamamallan November 17, 2025 14:48

Copilot AI reviewed Nov 17, 2025

View reviewed changes

adhityamamallan force-pushed the history-header branch from 9661542 to 6df1f23 Compare November 18, 2025 12:36

adhityamamallan added 2 commits November 18, 2025 13:37

New history V2 header

070d9f5

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

Make new history-v2 component

b6ad23f

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

adhityamamallan force-pushed the history-header branch from 6df1f23 to b6ad23f Compare November 18, 2025 12:37

adhityamamallan requested a review from Copilot November 18, 2025 12:37

Copilot started reviewing on behalf of adhityamamallan November 18, 2025 12:37 View session

Copilot finished reviewing on behalf of adhityamamallan November 18, 2025 12:40

Copilot AI reviewed Nov 18, 2025

View reviewed changes

adhityamamallan added 2 commits November 18, 2025 13:48

Address comments

9bfbff4

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

Clean up v2 flags and changes from v1 code

d7fd4ed

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

adhityamamallan changed the title ~~feat: New header for Workflow History V2~~ feat: New components for Workflow History V2 Nov 18, 2025

adhityamamallan requested a review from Copilot November 18, 2025 12:50

Copilot started reviewing on behalf of adhityamamallan November 18, 2025 12:50 View session

Copilot finished reviewing on behalf of adhityamamallan November 18, 2025 12:51

Copilot AI reviewed Nov 18, 2025

View reviewed changes

Resolve copilot comment

92fddc5

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

adhityamamallan marked this pull request as ready for review November 18, 2025 13:08

Assem-Uber approved these changes Nov 18, 2025

View reviewed changes

src/views/workflow-history/workflow-history-wrapper/__tests__/workflow-history-wrapper.test.tsx Outdated Show resolved Hide resolved

Address nit

25acc5e

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

adhityamamallan merged commit 3159d00 into cadence-workflow:master Nov 18, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: New components for Workflow History V2#1082

feat: New components for Workflow History V2#1082
adhityamamallan merged 6 commits intocadence-workflow:masterfrom
adhityamamallan:history-header

adhityamamallan commented Nov 17, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

adhityamamallan commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Sticky header preview (with large content)

On narrow screens

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

adhityamamallan commented Nov 17, 2025 •

edited

Loading