feat: Add grouped table with raw JSON of events#1093
Merged
adhityamamallan merged 4 commits intocadence-workflow:masterfrom Nov 25, 2025
Merged
feat: Add grouped table with raw JSON of events#1093adhityamamallan merged 4 commits intocadence-workflow:masterfrom
adhityamamallan merged 4 commits intocadence-workflow:masterfrom
Conversation
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a grouped table view for workflow history v2 that displays raw JSON representations of event groups. The implementation sets up the infrastructure for virtualized rendering of workflow history events with pagination support.
Key Changes:
- Added virtualized table component using react-virtuoso for displaying grouped workflow events
- Integrated data fetching, grouping, and filtering logic from existing workflow history utilities
- Implemented automatic loading behavior based on visible range and missing events
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/views/workflow-history-v2/workflow-history-v2.types.ts |
Replaced unused color types with new VisibleHistoryRanges type to track visible event indices |
src/views/workflow-history-v2/workflow-history-v2.tsx |
Added comprehensive data fetching, grouping, filtering logic and conditional rendering for grouped/ungrouped views |
src/views/workflow-history-v2/workflow-history-grouped-table/workflow-history-grouped-table.types.ts |
Defined props interface for grouped table component including virtuoso ref and event fetching callbacks |
src/views/workflow-history-v2/workflow-history-grouped-table/workflow-history-grouped-table.tsx |
Implemented virtualized table with temporary JSON.stringify rendering and load more functionality |
src/views/workflow-history-v2/workflow-history-grouped-table/__tests__/workflow-history-grouped-table.test.tsx |
Added comprehensive test suite covering header rendering, data display, and load more functionality |
src/views/workflow-history-v2/__tests__/workflow-history-v2.test.tsx |
Enhanced tests with MSW mocking, suspense handling, and scenarios for loading states and view toggling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/views/workflow-history-v2/workflow-history-grouped-table/workflow-history-grouped-table.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Assem-Uber
reviewed
Nov 25, 2025
...-history-v2/workflow-history-grouped-table/__tests__/workflow-history-grouped-table.test.tsx
Outdated
Show resolved
Hide resolved
src/views/workflow-history-v2/config/workflow-history-fetch-events-throttle-ms.config.ts
Outdated
Show resolved
Hide resolved
Assem-Uber
approved these changes
Nov 25, 2025
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Unit tests + ran locally.