Skip to content

feat: Add grouped table with raw JSON of events#1093

Merged
adhityamamallan merged 4 commits intocadence-workflow:masterfrom
adhityamamallan:history-v2-grouped-table
Nov 25, 2025
Merged

feat: Add grouped table with raw JSON of events#1093
adhityamamallan merged 4 commits intocadence-workflow:masterfrom
adhityamamallan:history-v2-grouped-table

Conversation

@adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Nov 24, 2025

Summary

  • Add fetching and grouping logic for Workflow History V2 page & components, based on the existing fetching logic for V1
  • Add grouped events table, with JSON placeholder for each event group row

Test plan

Unit tests + ran locally.

Screenshot 2025-11-24 at 17 43 49 Screenshot 2025-11-24 at 17 44 10

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a grouped table view for workflow history v2 that displays raw JSON representations of event groups. The implementation sets up the infrastructure for virtualized rendering of workflow history events with pagination support.

Key Changes:

  • Added virtualized table component using react-virtuoso for displaying grouped workflow events
  • Integrated data fetching, grouping, and filtering logic from existing workflow history utilities
  • Implemented automatic loading behavior based on visible range and missing events

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/views/workflow-history-v2/workflow-history-v2.types.ts Replaced unused color types with new VisibleHistoryRanges type to track visible event indices
src/views/workflow-history-v2/workflow-history-v2.tsx Added comprehensive data fetching, grouping, filtering logic and conditional rendering for grouped/ungrouped views
src/views/workflow-history-v2/workflow-history-grouped-table/workflow-history-grouped-table.types.ts Defined props interface for grouped table component including virtuoso ref and event fetching callbacks
src/views/workflow-history-v2/workflow-history-grouped-table/workflow-history-grouped-table.tsx Implemented virtualized table with temporary JSON.stringify rendering and load more functionality
src/views/workflow-history-v2/workflow-history-grouped-table/__tests__/workflow-history-grouped-table.test.tsx Added comprehensive test suite covering header rendering, data display, and load more functionality
src/views/workflow-history-v2/__tests__/workflow-history-v2.test.tsx Enhanced tests with MSW mocking, suspense handling, and scenarios for loading states and view toggling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
@adhityamamallan adhityamamallan marked this pull request as ready for review November 25, 2025 10:13
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
@adhityamamallan adhityamamallan merged commit 992c152 into cadence-workflow:master Nov 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants