fix: Pending events are not showing in some cases#1098
Merged
Assem-Uber merged 2 commits intocadence-workflow:masterfrom Dec 2, 2025
Conversation
Assem-Uber
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where pending events weren't being displayed in the workflow history timeline when they were fetched after the initial history load. The issue occurred because the Grouper class wasn't notifying subscribers after processing pending events.
- Added subscriber notification after pending events are processed in
processPendingEventsmethod - Added comprehensive test coverage to validate that
onChangecallbacks are triggered after pending event processing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/views/workflow-history/helpers/workflow-history-grouper.ts | Added subscriber notification after pending events are processed, ensuring the History component is notified of state changes |
| src/views/workflow-history/helpers/tests/workflow-history-grouper.test.tsx | Added test case to verify that subscribers are notified after pending events processing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adhityamamallan
approved these changes
Dec 2, 2025
Assem-Uber
deleted the
fix/17027/grouper-not-notifying-subsicribers-on-pending-updates
branch
adhityamamallan
pushed a commit
to adhityamamallan/cadence-web
that referenced
this pull request
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pending events are not showing on history in some cases as the
Grouperdoesn't notifyHistorycomponent that groups are updated. This happens in few cases when the pending events are fetched after the history timeline is loaded.Fix
Testing
onChangeis called after pending events processingBefore:
After:
