fix: History page filter error when initial event is selected#1100
Merged
Assem-Uber merged 1 commit intocadence-workflow:masterfrom Dec 2, 2025
Conversation
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
adhityamamallan
approved these changes
Dec 2, 2025
Assem-Uber
deleted the
fix/17013/filter-error-when-initial-event-is-selected
branch
adhityamamallan
pushed a commit
to adhityamamallan/cadence-web
that referenced
this pull request
Dec 3, 2025
Signed-off-by: Assem Hafez <assem.hafez@uber.com> Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
History page errors out when an event exists in the url and then filters is change to a value that filters out this event.
Fix
Tolerat the absense of selected event in
filteredEventGroupsEntriesby checking if it exists before accessing sub fields.Tests