fix: History stop loading more events if filters has no loaded events#1101
Merged
Assem-Uber merged 2 commits intocadence-workflow:masterfrom Dec 2, 2025
Conversation
…as-no-events-in-already-fetched-pages
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the workflow history would stop loading additional events when using filters that had no matching events in the already-loaded page. The fix ensures the loading spinner continues to display as long as there are more history pages to fetch, only showing "No Results" after reaching the end of available history.
- Modified the condition for displaying "No Results" to check both empty filtered events AND absence of next page
- Added conditional rendering for the compact section virtuoso list in grouped view
- Enhanced test coverage with three new test cases covering different pagination scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/views/workflow-history/workflow-history.tsx | Updated showHasNoResults logic to consider hasNextPage, wrapped compact section virtuoso in conditional check for non-empty filtered events |
| src/views/workflow-history/tests/workflow-history.test.tsx | Added test cases to verify "No Results" displays correctly based on pagination state and filtered events |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adhityamamallan
approved these changes
Dec 2, 2025
adhityamamallan
pushed a commit
to adhityamamallan/cadence-web
that referenced
this pull request
Dec 3, 2025
…ence-workflow#1101) Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
History stops loading if a filter is used that has no events in the already loaded page. This happens due to hiding the loading spinner that is responsible of loading more pages and showing
No resultsearly.Fix
The fix is to keep showing loading spinner as long as there are next history pages to load and show only no results on reaching the end of the history. The spinner is within the main list virtouso
Testing
Screen.Recording.2025-12-02.at.14.20.52.mov